Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SPAWNER_LINK xpath #1880

Merged
merged 1 commit into from
Oct 3, 2024
Merged

update SPAWNER_LINK xpath #1880

merged 1 commit into from
Oct 3, 2024

Conversation

ConorOM1
Copy link
Contributor

@ConorOM1 ConorOM1 commented Oct 2, 2024

The xpath text has been changed for the Jupyter launch button. This fix updates the SPAWNER_LINK variable to reflect the change

Fixes ODS-1877

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
547 0 0 547 100

@manosnoam
Copy link
Contributor

Conor, can you find data-testid instead of text ?

@jstourac
Copy link
Member

jstourac commented Oct 2, 2024

Conor, can you find data-testid instead of text ?

@manosnoam I just checked, I think there isn't any:

image

So maybe you should ask in dashboard to add one?

@ConorOM1
Copy link
Contributor Author

ConorOM1 commented Oct 2, 2024

@manosnoam as above i couldn't see any data-testid for this element. Is there a process to get these added ?

@jstourac jstourac merged commit 8e246b7 into red-hat-data-services:master Oct 3, 2024
8 checks passed
jiridanek added a commit to jiridanek/odh-dashboard that referenced this pull request Oct 3, 2024
@jiridanek
chore(quality): add data-testid for the Launch standalone notebook se…
2826c85 
…rver button

* red-hat-data-services/ods-ci#1880 (comment)
@jiridanek jiridanek mentioned this pull request Oct 3, 2024
Merged
6 tasks
@jiridanek
Copy link
Member

@manosnoam as above i couldn't see any data-testid for this element. Is there a process to get these added ?

Let's see if I can just add it directly

@jstourac
Copy link
Member

jstourac commented Oct 3, 2024

Let's see if I can just add it directly

LOL, you rock, Jiri! 🎸 🚀 😁

@ConorOM1
Copy link
Contributor Author

ConorOM1 commented Oct 3, 2024

@manosnoam as above i couldn't see any data-testid for this element. Is there a process to get these added ?

Let's see if I can just add it directly

Wow ! Magic !

openshift-merge-bot bot pushed a commit to opendatahub-io/odh-dashboard that referenced this pull request Oct 6, 2024
@jiridanek
chore(quality): add data-testid for the Launch standalone notebook se…
85ce695 
…rver button (#3294)

* red-hat-data-services/ods-ci#1880 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac approved these changes

@jiridanek jiridanek jiridanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ConorOM1 @manosnoam @jstourac @jiridanek